feat(frontend): Support flow control (backpressure) visualization in frontend#4295
Draft
yunyad wants to merge 2 commits intoapache:mainfrom
Draft
feat(frontend): Support flow control (backpressure) visualization in frontend#4295yunyad wants to merge 2 commits intoapache:mainfrom
yunyad wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
|
@yunyad I suggest you to use github issues to track multiple steps of task. Adding [1/3] [3/3] in the PR title is not ideal: the pr could get reverted, redo, or you may need an extra step 4 after you finish first 3. Using issues and sub-issues would be easier to manage these. Thanks. |
Contributor
|
@yunyad ? |
Contributor
Author
|
@Yicong-Huang Thanks for the suggestion. I can create a tracking issue with sub-issues and link all PRs there, and remove the [1/3] style from the titles. I’ll update soon. @chenlica could you clarify are you asking for an update, or do you have a concern with the approach? Thank you! |
yunyad
changed the title
Contributor
|
@yunyad I was asking you to reply to @Yicong-Huang's suggestions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Any related issues, documentation, discussions?
How was this PR tested?
Was this PR authored or co-authored using generative AI tooling?